sds / haml-lint / 32325806152

97%

push

github

Add support for Haml 7.4 (#693)

## Summary

Haml 7.4 broke Haml-Lint for **any template containing interpolation**.

`Haml::Util#unescape_interpolation` dropped its `escape_html` parameter
in haml/haml#1217 ([`78ddd14`][sig]), released in 7.4.0 (7.3.1 still has
it). That commit moved escaping of interpolated tag text out of the
parse-time string literal and into `Haml::Escape`, so the parameter,
whose only job was to bake `Haml::Util.escape_html_safe(...)` into that
literal, was left without callers and removed with it. Haml-Lint monkey
patches that method in
`lib/haml_lint/extensions/haml_util_unescape_interpolation_tracking.rb`
to keep a map of interpolated string → original source, which the
RuboCop auto-correct round-trip depends on. The patch forwarded two
arguments unconditionally, so under 7.4 every parse blew up with:

```
ArgumentError: wrong number of arguments (given 2, expected 1)
# lib/haml_lint/extensions/haml_util_unescape_interpolation_tracking.rb:28
# lib/haml_lint/adapter/haml_6.rb:30:in 'HamlLint::Adapter::Haml6#parse'
# lib/haml_lint/document.rb:109:in 'HamlLint::Document#process_source'
```

Since #690 relaxed the `haml` constraint to have no upper bound, users
on `haml 7.4` hit this immediately.

## Fix

Forward the extra arguments as-is, so the patch works against both
signatures:

```ruby
def unescape_interpolation_with_original_tracking(str, *args)
  value = unescape_interpolation_without_original_tracking(str, *args)
```

Also adds a `haml7.4` appraisal and wires it into the CI matrix, so the
next signature change is caught by CI rather than by users.

## Notes

- Scoped to 7.4 only. Haml 7.3 support is already covered by #692, which
needs no code change (the signature only changed in 7.4.0). This PR will
conflict textually with #692 on `Appraisals`,
`.github/workflows/tests.yml` and `CHANGELOG.md`, all three are one-line
insertions at the same spot, resolved by keeping both entries in order.
- `gemfiles/haml7.4.gemfile` int... (continued)

2 of 2 new or added lines in 1 file covered. (100.0%)

3153 of 3234 relevant lines covered (97.5%)

25095.68 hits per line