fktn-k / fkYAML / 32318064919

100%

push

github

Hold parse context node ownership in a unique_ptr (#563)

* Hold parse context node ownership in a unique_ptr

A parse context either borrows a node from the result tree or owns a node
until that node is grafted into the tree. That distinction was derived from
the mutable state member, which the parsing code rewrites while the node is
still owned: the default branch of the flow collection handlers turns a
FLOW_MAPPING_KEY context into a FLOW_MAPPING one, after which the destructor
no longer freed the node it still owned.

Hold the owned node in a std::unique_ptr member instead, make parse contexts
move-only so ownership cannot be duplicated by a copy, and decide whether a
closing flow collection is a mapping key from that member rather than from the
state. The manual delete calls and the destructor which freed a raw pointer
based on the state are gone.

This fixes the leaks reported in #536 for "{{{", "? [" and "? []", and the
same leak for "{{{}},{" and "{{{}},[", which are already covered by the
regression tests added in #552 and currently make ci_test_clang_sanitizers
fail on develop.

* Exclude the empty context stack guard from the coverage measurement

Nothing reaches the throw in `current_context()` anymore: the inputs which used
to, the flow collection beginnings from #536, now fail a step earlier. The
guard stays anyway, since the alternative for a caller is dereferencing an
invalid iterator, so mark it like the identical one in `pop_to_parent_node()`.

* Move the key node out of the context which owns it

Co-Authored-By: fktn <fktn.dev@gmail.com>

---------

Co-authored-by: fktn <fktn.dev@gmail.com>

1514 of 1514 branches covered (100.0%)

Branch coverage included in aggregate %.

38 of 38 new or added lines in 1 file covered. (100.0%)

5324 of 5324 relevant lines covered (100.0%)

1727.09 hits per line