FEniCS / ffcx / 32298466373

86%

main: 85%

Build Type

Pull #865

github

Committed by garth-wells

Commit Message

Fix mypy errors from the perf-stack merge

definitions.py: the unrolled coordinate-dofs sum (#862) shadowed the
outer-scope 'tables' name with a fresh annotated list, which mypy
flags as a redefinition -- rename to 'coord_tables'. Also assert
tabledata.offset is not None once, narrowing 'begin' from int | None
for both the loop and unrolled code paths (the loop path's index
expression built through the LExpr type happened not to trigger the
same check).

integral_generator.py: annotate 'decomps' (empty list gives mypy
nothing to infer from) and check 'bases is not None' alongside
'shared is not None' before zipping, since narrowing 'shared' alone
left 'bases' as list[LExpr] | None at the zip() call.

Pull Request Pull Request #865: Stack codegen performance fixes: quadrature-loop split, tensor contraction, CSE, coordinate unrolling, LICM fusion

Coverage Stats

274 of 316 new or added lines in 4 files covered. (86.71%)

2 existing lines in 2 files now uncovered.

4472 of 5268 relevant lines covered (84.89%)

0.85 hits per line