stacklok / toolhive / 32282977351

70%

Build Type

push

github

Committed by web-flow

Commit Message

Add plugin lock-file sync (#6316)

* Add plugin lock-file sync

Restore project plugins from the lock file via thv ai-plugin sync
and POST /plugins/sync, gated by TOOLHIVE_PLUGINS_LOCK_ENABLED.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Fix adopt rollback and add plugin sync e2e

A failed DB update after writing the lock entry left the plugin
untracked; remove the entry so the next sync can retry. Cover
thv ai-plugin sync exit codes the same way skills lock does.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Require restorable pins and client health on sync

Sync must not report a plugin current when a requested client is
missing or marketplace registration is gone, and must refuse to
adopt a local tag that cannot be restored later.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Serialize adopt and restore the prior lock pin

Adoption must hold the per-plugin lock and put back the
pre-existing entry if marking Managed fails.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Reconcile each plugin under its lock on sync

A stale lock/DB snapshot can resurrect uninstalls; default
sync must also expand to newly detected clients.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Make plugin sync use detected clients and locked helpers

Default sync targets installed plugin clients, validates pinned
canonical names before mutate, and drops context lock reentrancy.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Drop unused adoptPlugin wrapper after locked sync

Sync already calls adoptLocked under the held mutex; remove the
dead public wrapper and quiet installFromOCI gocyclo.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Expand sole clients all sentinel on plugin sync

A lone --clients all now matches the documented detected-client
default instead of failing validation on every sync.

Signed-off-by: Samuele Verzi <samu@stacklok.com>

* Match unified update hook signature in adopt test

Signed-off-by: Samuele Verzi <... (continued)

Coverage Stats

383 of 585 new or added lines in 12 files covered. (65.47%)

24 existing lines in 6 files now uncovered.

86649 of 122917 relevant lines covered (70.49%)

101.82 hits per line