umputun / docker-logger / 32267610063

79%

master: 80%

Build Type

Pull #62

github

Committed by paskal

Commit Message

Fix startup deadlock and event loss in discovery

Previously, NewEventNotif emitted the initial container snapshot into a channel
with a fixed buffer of 100 while the consumer could not start until the
constructor returned, so with more than 100 allowed running containers the send
blocked forever and no logging began. After this change the snapshot is
collected first and the events channel is sized to fit it.

The docker events listener channel was unbuffered, and the client drops events
for any listener which is not immediately ready, so events were lost whenever
the consumer was busy. The listener channel is buffered now.

Pull Request Pull Request #62: Fix startup deadlock and event loss in discovery

Coverage Stats

16 of 16 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

389 of 491 relevant lines covered (79.23%)

27.01 hits per line