oetiker / callbackery / e6c06b90e
22%

DEFAULT BRANCH: master
Ran
Jobs 10
Files 189
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 21.772% (+3.7%) from 18.081%
e6c06b90e

push

github

web-flow 
Declare some modules as a test dependency (#246)

* Declare Mojo::SQLite as a test dependency

t/config-restore.t, added in 0.58.3, opens the config database, and
CallBackery::Database loads Mojo::SQLite to do so. The module has not
been a declared dependency since 774d1f8 removed it in 2017 -- the
require is lazy, so a Pg-backed installation does not need it -- and
nothing put it back for the tests. CI has been red since 0.58.3 with
"Can't locate Mojo/SQLite.pm in @INC" from t/config-restore.t.

Declare it in TEST_REQUIRES rather than PREREQ_PM: MY::postamble merges
TEST_REQUIRES into the module list "make thirdparty" installs, so the
tests get it, while the runtime requirements stay as they were.

(The "unexpected OP_CUSTOM (await)" lines the CI log is annotated with
are unrelated noise: Devel::Cover deparses ops, and B::Deparse does not
know Future::AsyncAwait's custom ops. They appear in green runs too.)

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* Declare Crypt::Rijndael as a test dependency too

Once Mojo::SQLite is available t/config-restore.t gets one step further
and dies on "Can't locate Crypt/Rijndael.pm": getConfigBlob() encrypts
the blob through CallBackery::Config::getCrypt, which requires the
module lazily. Same situation as Mojo::SQLite, same treatment.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* invalidPlugin.t: expect the real error, not the missing-module crash

The test asserted the generic 9999 "Couldn't process request" and was
green -- but not because CallBackery handled the invalid plugin that
way. Mojo::SQLite was not installed, so the request died in
CallBackery::Database before the plugin was ever looked up, and that
crash was what got sanitised:

  [error] Error while processing default::processPluginData:
          Can't locate Mojo/SQLite.pm in @INC ...
  [error] JsonRPC error sent to client: '9999: Couldn't process request'

With the module declared the request reaches... (continued)

6867 of 31541 relevant lines covered (21.77%)

63.25 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
44.74
 -5.26% thirdparty/lib/perl5/Mojo/Exception.pm
4
56.25
 2.5% thirdparty/lib/perl5/Mojolicious/Plugin/Qooxdoo/JsonRpcController.pm
3
18.75
 0.0% thirdparty/lib/perl5/Mojolicious/Sessions.pm
2
26.67
 -0.92% thirdparty/lib/perl5/Mojo/Cookie/Response.pm
1
83.52
 -1.1% thirdparty/lib/perl5/Mojolicious.pm
Jobs
ID Job ID Ran Files Coverage
1 e6c06b90e.1 189
21.77
2 e6c06b90e.2 189
21.77
3 e6c06b90e.3 188
21.76
4 e6c06b90e.4 189
21.77
5 e6c06b90e.5 188
21.76
6 e6c06b90e.6 189
21.77
7 e6c06b90e.7 189
21.77
8 e6c06b90e.8 189
21.77
9 e6c06b90e.9 189
21.77
10 e6c06b90e.10 189
21.77
Source Files on build e6c06b90e