zhaozg / lua-openssl / 32259708810

93%

Build Type

push

travis-ci

Committed by zhaozg

Commit Message

fix(cms): never push NULL reason string on error paths

openssl_pushresult() called ERR_reason_error_string() and pushed the
result directly. For error codes without a registered reason table
(e.g. provider 'could not load the shared library' errors), the function
returns NULL, so lua_pushstring(L, NULL) pushed nil instead of an error
message. Callers then received nil, nil, code instead of nil, msg, code,
which broke the documented error contract (test 6.cms.lua:138 expected a
non-nil error for c:detached(true) on an empty cms.new() object).

Guard the reason lookup and fall back to "UNKNOWN ERROR" while still
exposing the raw error code. Apply the same guard to
openssl_error_string() to keep the error() API consistent.

Coverage Stats

5 of 5 new or added lines in 2 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

10668 of 11482 relevant lines covered (92.91%)

2243.9 hits per line