qmuntal / gltf / 32171484450

88%

master: 88%

Pull #104

github

Reject out-of-range GLB BIN byteLength and make test portable

A GLB BIN chunk length is a uint32, but buffer.ByteLength is an int read
from untrusted JSON. On 64-bit platforms a byteLength above 2^32-1 would
be silently truncated by the uint32 conversions in the BIN header check,
so an oversized value could spuriously pass the bounds check. Reject any
byteLength outside the uint32 range up front.

Also skip the oversized-buffer regression test on platforms where the
~4 GiB byteLength does not fit in int, so it doesn't fail on 32-bit for
reasons unrelated to the behavior under test.

Signed-off-by: Chris (ChrisJr404) <11917633+ChrisJr404@users.noreply.github.com>

7 of 11 new or added lines in 1 file covered. (63.64%)

2801 of 3171 relevant lines covered (88.33%)

101.58 hits per line