decentraland / signatures-server / 32249494236

92%

push

github

fix(auth): upgrade @dcl/crypto-middleware to 6.1 (#489)

6.0.0 joins the metadata bytes into the signed payload instead of
lowercasing them, so metadata casing is covered by the signature.

The scene gate moves from a local withSignerValidation middleware to
rejectIfSigner on the same route's wellKnownComponents call. The local
middleware existed because the library's guard could not be relied on —
its own comment said so — and it compensated by folding the signer with
trim().toLowerCase() before comparing. The predicate refuses a
non-canonical signer instead, so the same requests are refused without any
value being rewritten.

Removes that middleware and its unit spec as now-dead code. Scope is
unchanged: it guarded exactly one route, POST /v1/rentals-listings, and
that route's wellKnownComponents call is where the predicate now sits.

Two differences a reviewer should weigh: the refusal moves before
signature verification rather than after, and the response body becomes
the middleware's JSON error rather than the plain 'Invalid signer' string.

345 of 372 branches covered (92.74%)

Branch coverage included in aggregate %.

680 of 746 relevant lines covered (91.15%)

48.5 hits per line