supabase / supabase-swift / 32239205546

87%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(functions)!: make FunctionsClient stateless and a struct (#1233)

* refactor(functions)!: make FunctionsClient stateless and a struct

FunctionsClient's only mutable state was a lock-protected Authorization
header mutated via `setAuth(token:)`. Replace it with an
`accessToken: (@Sendable () async throws -> String?)?` closure,
resolved fresh before every request instead of cached on the client.
`SupabaseClient`'s internal `functions.setAuth(...)` call is removed
too: it was already redundant, since `SupabaseClient`'s fetch handler
overwrites `Authorization` on every request with the live session
token.

With no mutable state left, every stored property is now a `let`, so
FunctionsClient becomes a `struct` instead of a `final class`.

* refactor(functions): stop caching FunctionsClient in SupabaseClient.mutableState

FunctionsClient holds no mutable state now, so there is nothing to gain
from memoizing one per SupabaseClient instance. Build and return a
fresh value on every access to SupabaseClient.functions instead.

* fix(functions): stop clobbering per-invocation Authorization overrides

SupabaseClient.functions wired FunctionsClient's `fetch` to
fetchWithAuth, which unconditionally overwrites `Authorization` with
the live access token on every outgoing request. That silently
clobbered a per-invocation header override passed via
FunctionInvokeOptions whenever a session was active, even though
FunctionsClient's own buildRequest already applies that override
correctly.

Give FunctionsClient a transport-only fetch (trace-context injection,
no auth) plus its own `accessToken` closure instead, mirroring the
fetch/accessToken split already used for RealtimeClientV2. The closure
captures `self` weakly (matching this file's no-self-capture
convention for sub-client closures) and swallows a missing-session
error, so anonymous invocations keep working instead of throwing.

* docs(supabase): trim redundant comment on functions property

The `fetchWithA... (continued)

Coverage Stats

0 of 45 new or added lines in 2 files covered. (0.0%)

112 existing lines in 2 files now uncovered.

8104 of 10447 relevant lines covered (77.57%)

32.57 hits per line