Mellanox / network-operator / 32228666185

63%

Build Type

push

github

Committed by web-flow

Commit Message

feat: support meta-plugins for secondary networks (#3028)

## What

- add the optional `spec.metaPlugins` field to `MacvlanNetwork` and
`HostDeviceNetwork`
- render a CNI configuration list with the primary plugin first,
followed by the supplied meta-plugins in their original order
- preserve the existing single-plugin `NetworkAttachmentDefinition` when
`metaPlugins` is empty
- regenerate both source and Helm CRDs, and document the new field

## Why

k8s-launch-kit uses one `secondaryNetworkMetaPlugins` helper across
non-Spectrum-X secondary-network profiles. SR-IOV profiles already work
because the SR-IOV Network Operator accepts `spec.metaPlugins`, but
launch-kit also emits the same field for Macvlan RDMA-shared and
host-device profiles. Network Operator did not expose that field or
build a CNI configuration list, leaving those generated profiles unable
to use either feature.

The launch-kit use cases are:

- `profile.routing: source-based` adds the `sbr` CNI plugin so traffic
sourced from a rail IP leaves through that rail's interface and gateway.
- `profile.ignoreARP: true` adds the `tuning` CNI plugin before `sbr`,
setting `arp_ignore=1`, `arp_announce=2`, and `rp_filter=0` at both
`all` and `IFNAME` scopes. This prevents ARP flux between pod rails from
advertising one rail's IP through another rail's VF/MAC and steering
RoCE traffic to the wrong HCA.

The API and fragment format intentionally match the established SR-IOV
Network Operator contract. This is additive and backwards compatible:
without `metaPlugins`, rendered NAD configuration is unchanged.

## Testing

- `go build ./...`
- `KUBEBUILDER_ASSETS=<envtest-assets> go test ./... -count=1`
- focused MacvlanNetwork and HostDeviceNetwork state rendering tests
with the launch-kit `tuning` + `sbr` fragment
- focused MacvlanNetwork and HostDeviceNetwork controller envtests
- `make lint`
- `make check-manifests`

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

13 existing lines in 5 files now uncovered.

5049 of 8004 relevant lines covered (63.08%)

45.37 hits per line