TrigenSoftware / srcset / 32228379940

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix: address the code review findings (#16)

- Variant selection: an explicit `select` or `?format=` no longer inherits
  the implicit width, and the fallback variant of a rule is documented
- Dev server addresses variants by the manifest key, so same-named images
  of different sources no longer serve each other's contents
- Variants resolving to one file are produced once, across rules as well
- EXIF orientation is applied instead of being dropped, so the variants and
  the reported dimensions match what a browser renders
- Glob matchers normalize the path, so the same rule matches on Windows
- The cli rejects unknown options instead of taking them for globs, and
  stops on an output path collision instead of overwriting silently
- `?placeholder` keeps the configured placeholder options
- The loader ships declarations without a hard `webpack` dependency, and its
  development names keep converted siblings apart
- An aborted dev request no longer leaks a file descriptor
- The preact peer range matches what the source actually needs
- Rule matching and deduplication moved into `SrcSetGenerator.generateAll`

Coverage Stats

504 of 567 branches covered (88.89%)

Branch coverage included in aggregate %.

75 of 82 new or added lines in 13 files covered. (91.46%)

2 existing lines in 1 file now uncovered.

698 of 744 relevant lines covered (93.82%)

94925.03 hits per line