go-pkgz / pool / 32205539369

97%

push

github

fix cancellation reported as successful completion (#9)

when the caller's context is cancelled and both input channels are closed, all
select cases are ready at once and the scheduler decides which one wins. taking
the drained-channel exit left lastErr nil, so Close reported success and
poolCompleteFn ran on an aborted run.

join the caller's context error into the both-closed exit, and the accumulated
lastErr into the cancellation exit, so both report the same thing. checked on the
context passed to Go rather than the errgroup one, which is also cancelled by a
failing worker and would misreport a peer's failure as caller cancellation.

9 of 9 new or added lines in 1 file covered. (100.0%)

623 of 644 relevant lines covered (96.74%)

155150.64 hits per line