go-pkgz / rest / 32204923861

97%

push

github

fix: order the gzip hijack error path so failures cannot corrupt the body (#56)

Closing the stream discarded its error and released the writer before the
hijack was attempted, which cost two things.

A failing Close means truncated gzip output, and a hijack succeeding right
after hid it. That error is returned now.

A failing Hijack left hijacked false with the writer already released, so a
handler carrying on would take the plain path and append raw bytes to a body
already advertised as Content-Encoding: gzip. The writer stays attached on that
path instead, and since it is closed a further write fails with "flate: closed
writer" rather than corrupting the response. The deferred close still returns it
to the pool, and the pool is safe because Reset clears the closed flag.

The writer is only released once Hijack has actually taken the connection.

Reported by umputun on #55.

14 of 14 new or added lines in 1 file covered. (100.0%)

1658 of 1706 relevant lines covered (97.19%)

47.3 hits per line