go-pkgz / notify / 32195443752

97%

Build Type

push

github

Committed by web-flow

Commit Message

Make telegram auth state changes single-writer (#40)

Auth requests were read under a read lock, changed on a copy and written
back later, so a request consumed by CheckToken in between was restored
from the stale copy and could be used again. Confirmation in
processUpdates is one locked transaction now, with the network calls kept
outside of it.

CheckToken had the same split between lookup and deletion, letting two
parallel calls both accept a one-time token; it is a single transaction
now as well.

Run counted the number of started goroutines instead of preventing them,
and ProcessUpdate checked that counter separately from taking the work.
Both go through one lock now: a second Run returns instead of starting
another processor, and ProcessUpdate holds it for the whole call. It is
a read lock, so parallel ProcessUpdate calls keep running concurrently
and only Run is excluded.

Coverage Stats

34 of 34 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

498 of 516 relevant lines covered (96.51%)

185.58 hits per line