go-pkgz / syncs / 32195109274

99%

push

github

Fix data race on error recording in ErrSizedGroup (#14)

* Fix data race on error recording in ErrSizedGroup

Previously, a worker stored the result of g.err.append(err) back into
g.err while a canceled Go call read the same field outside the lock,
which the race detector flags. MultiError.append mutates and returns its
own receiver, so the assignment was redundant; dropping it makes the
field write-once and removes the need for errLock, as MultiError is
already thread safe on its own.

* Add race regression test, relax termination bound in cancel tests

The cancel tests allowed 110 started goroutines, but 111 is reachable:
100 submitted before the cancellation, up to 10 running and one more
waiting for the semaphore.

2 of 2 new or added lines in 1 file covered. (100.0%)

170 of 172 relevant lines covered (98.84%)

1859.09 hits per line