PHPOffice / PHPPresentation / 32178444798

93%

push

github

Mark a shape as decorative (#899)

* feat: mark a shape as decorative

A shape that carries no information — a coloured band, a rule, a background
image — is announced by assistive technologies like any other, which forces
blind users through content that means nothing. Both formats can say otherwise,
and the library could not.

Add a three-state `decorative` flag to `AbstractShape`: null (the default) writes
nothing, true and false state the case explicitly. PowerPoint2007 writes it as
the `{C183D7F6-B498-43B3-948B-1728B52AA6E4}` extension of `p:cNvPr` for every
shape kind, sharing the extension list with the SVG creation id where a picture
already has one. ODPresentation writes the `loext:decorative` attribute, the
LibreOffice extension standardized in ODF 1.4 — which is why the ODF test asserts
the 1.2 schema rejects it, as the existing `loext:mime-type` test does.

Closes #705

* feat: read the decorative flag back from documents

The PowerPoint2007 reader restores it from the `{C183D7F6-...}` extension of
`p:cNvPr` for rich text, pictures, tables and charts; the ODPresentation reader
from the `loext:decorative` attribute of the frame.

* fix: keep the reader coupling below the PHPMD threshold

Reading the decorative flag added a dependency on AbstractShape to both
readers, which pushed PowerPoint2007 over the limit. The helper returns the
flag instead of applying it, so the readers keep the same dependencies as
before.

* docs: changelog entry for the decorative flag

* refactor: the decorative flag is a plain bool

A shape is decorative or it is not: the third state said "the document
does not say", which the absent attribute already says. False and absent
mean the same thing to both formats, so false now writes nothing instead
of an attribute no reader can tell from its default.

56 of 58 new or added lines in 5 files covered. (96.55%)

10122 of 10990 relevant lines covered (92.1%)

44.29 hits per line