GrottoCenter / grottocenter-api / 32169453721

91%

Build Type

push

github

Committed by ClemRz

Commit Message

fix(recentChanges): address code review findings from PR #1776

- Add change_history, change_location, change_description, change_rigging
  triggers to CREATE_SUB_ENTITY_TRIGGERS in test/customSQL.js and wire into
  seed-database.js so all five sub-entity triggers (not just change_comment)
  are installed in the test DB and exercised by the regression suite
- Fix asymmetric subAction priority in groupChanges(): add a guard that
  preserves an existing 'create' or 'restore' subAction when an incoming
  'update' for the same entity arrives, preventing it from being downgraded
  to 'change' — the reverse of the already-handled update→create upgrade
- Remove redundant self-assignment g.subActionEntityId = c.id_entity inside
  the same-entity guard where equality is already confirmed by the condition
- Add inline comment at the Model.tableName interpolation in RelevanceService
  recording that the value is safe because entityType was validated via
  getConfig() earlier in the call stack

Coverage Stats

5171 of 6204 branches covered (83.35%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

4 existing lines in 2 files now uncovered.

9528 of 10619 relevant lines covered (89.73%)

142.07 hits per line