kubernetes-sigs / ibm-vpc-block-csi-driver / 32138508948

74%

master: 83%

push

github

fix: return NodeExpansionRequired=false for raw block volumes (#272)

* fix: return NodeExpansionRequired=false for raw block volumes in ControllerExpandVolume

Raw block volumes (volumeMode: Block) have no filesystem, so kubelet
has nothing to do at the node side after a controller-side resize.
Returning NodeExpansionRequired: true unconditionally causes
external-resizer to set FileSystemResizePending on the PVC, which
only clears when kubelet calls NodeExpandVolume. For block PVCs with
no pod ever mounting them, the condition is permanently stuck, and
external-resizer stops issuing ControllerExpandVolume RPCs entirely —
silently preventing all subsequent resizes from reaching the backend.

Fix: check the VolumeCapability access type from the request and
return NodeExpansionRequired: false when it is VolumeCapability_Block.

Matches the pattern used by vsphere-csi-driver (controller.go:2025).

Signed-off-by: Mahantesh R <mahantesh@example.com>

* modifies the unit tests

* adds check on volumeCapability

---------

Signed-off-by: Mahantesh R <mahantesh@example.com>

7 of 7 new or added lines in 1 file covered. (100.0%)

1421 of 1932 relevant lines covered (73.55%)

13.5 hits per line