IgniteUI / igniteui-webcomponents / 32132682942

98%

Build Type

push

github

Committed by web-flow

Commit Message

fix(icon): repair reference resolution, SVG metadata and internal icons (#2339)

Fixes:
- An icon rendered through a reference stayed blank when its target was
  registered afterwards - notifications were matched against the host's own
  name and collection, not the resolved target. It now re-resolves on any
  registry change.
- `stripMeta` removed only the first `<title>`/`<desc>` at any depth, so packs
  carrying metadata per shape kept their native tooltip. All are stripped now,
  and the `aria-label` comes from a root-level `<title>` only.
- `role="img"` was declared unconditionally, leaving decorative icons in the
  accessibility tree as unnamed images. It is now set only when the icon has
  a name of its own or the host is labelled.
- Internal `open_in_new` had no `viewBox` and rendered a quarter undersized in
  the corner; `indigo_search` had an unclosed `<path>`. A spec now parses every
  internal icon and checks its viewBox.
- The registry threw on construction under SSR - `DOMParser` and
  `globalThis.addEventListener` are absent in Node. The parser is now lazy and
  the broadcast is inert when `isServer`.

Performance:
- Alias resolution was a 62-entry linear scan per icon per render;
  `ICON_REFERENCES` is a Map.
- Subscribers are notified once per microtask instead of once per changed icon
  key, so N registrations with M icons mounted no longer cost N*M callbacks.
- Client-side icons render in one pass; only genuinely hydrating hosts pay the
  second update cycle the SSR guard used to impose on all of them.

No public API changes; the behavioral ones are in the changelog.

Coverage Stats

6892 of 7235 branches covered (95.26%)

Branch coverage included in aggregate %.

292 of 300 new or added lines in 7 files covered. (97.33%)

2 existing lines in 1 file now uncovered.

48256 of 48880 relevant lines covered (98.72%)

1458.81 hits per line