nledez / tun-manager / 32122187566
100%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 28
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 99.429% (-0.2%) from 99.628%
32122187566

push

github

nledez 
test: hold the publisher back so the drop test stops racing

TestDroppingOneClientLeavesTheOthersServed failed on CI, and reproduces
locally under GOMAXPROCS=1 on nearly every run. The test published flat
out until the count fell, but a client's queue is sixteen deep: on a
machine with no spare core the attentive client's reader is not scheduled
often enough to stay inside that, so it fills up and is dropped by the
very policy under test. Both clients go, and the count lands on 0.

The test was measuring throughput rather than the policy. It could fail
the wrong way too - a count of 1 says nothing about which client survived,
and the run that reported "the attentive client received no state at all"
was a pass on the count with the wrong survivor.

publishUntil now takes the send step from its caller, and the two-client
test snapshots the state count, publishes one view, and waits for the
attentive client to take it off the wire before publishing the next. A
client held one message from current cannot fall sixteen behind, so the
only one that can is the one that never reads. The single-client test
keeps publishing unthrottled: nobody there is meant to survive.

waitFor is eventually for callers that are not the test's own goroutine.
Failing a test from anywhere else is undefined, and the publishing loop
runs on a goroutine of its own so that a Publish that blocks is caught
rather than hanging the run.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

2614 of 2629 relevant lines covered (99.43%)

40.22 hits per line

Coverage Regressions

Lines Coverage ∆ File
7
97.63
 0.68% main.go
Jobs
ID Job ID Ran Files Coverage
1 32122187566.1 28
99.43
 GitHub Action Run
Source Files on build 32122187566