PHPOffice / PHPPresentation / 32119246456

93%

push

github

fix: the ODPresentation writer draws the chart it was given (#901)

Five defects of the chart output, each of them visible when the
document is opened in LibreOffice :

- a serie wrote a single `chart:data-point` repeated once, so only the
  first value was drawn ; the points taking the style of the serie are
  now counted and their run written with the right `chart:repeated`
- the chart style wrote `draw:fill-color` without `draw:fill`, and the
  ODF default being a solid fill, every chart came out on a black
  background
- the legend was written whatever `Legend::isVisible()` said
- `chart:data-label-number` was written on the style of the serie only,
  where LibreOffice reads it from the style of the plot area, so the
  values never showed
- a serie leaving its fill untouched wrote `draw:fill="none"` and came
  out transparent ; it now says nothing about its colour, as the OOXML
  writer already does, and the application picks one

The charts LibreOffice writes itself carry `chart:repeated` summing to
the number of values, an explicit `draw:fill` on the chart style and a
`draw:fill-color` without `draw:fill` on the style of a serie.

39 of 39 new or added lines in 1 file covered. (100.0%)

9910 of 10814 relevant lines covered (91.64%)

43.67 hits per line