sandialabs / LoQS / 32096351089

88%

push

github

SERIALIZATION_VERSION bump to version 2 (#113)

* Fix _get_cumulative_changes's infinite loop and a latent KeyError

_get_cumulative_changes's `while version < SERIALIZATION_VERSION` loop
never incremented `version`, causing an infinite loop once more than
one version hop separates an object's recorded version from
`SERIALIZATION_VERSION`; replaced with a `for` loop over the actual
range. Also fixes a related bug: both
`IMPORT_LOCATION_CHANGES_BY_VERSION[...]` lookups assumed every
version has a table entry, raising `KeyError` for a version bump with
no import-location changes; switched both to `.get(..., {})`. Adds
regression tests for a 3-hop rename composition and a missing
middle-version entry.

* Bump SERIALIZATION_VERSION to 2 with a version-dispatch decode registry

Introduces `VersionedDecoder` (`loqs/internal/versioning.py`), a small
registry mapping a serialization version to the decoder for that
version's on-disk shape, replacing every hardcoded `!= 1`/`== 1`
version-bound check across both encoders.

- Converts every decode site in `jsonencoder.py`/`hdf5encoder.py` to
  register one self-contained decoder per version, aliasing version 2
  to version 1 everywhere (version 2 introduces no new on-disk shape);
  an unregistered version now raises `DecodableVersionError` cleanly.
- Bumps `SERIALIZATION_VERSION` to 2 and adds
  `IMPORT_LOCATION_CHANGES_BY_VERSION[2]`: the 14 `*CastableTypes` ->
  `*Like` renames, plus `None`-sentinel entries (widening the table's
  value type to allow "deleted, not relocated") for
  `DictModelCastableTypes`/`Castable`/`SeqCastable`/`MapCastable`.
- Moves `SyndromeLabelCastableTypes`'s rename out of version 1's entry
  into its own version-2 entry.
- Adds a coverage test asserting every registry has a decoder for
  every version it should, plus regression tests for the rename,
  version-bound rejection, and the registry mechanism itself.

* Add generic legacy-compatibility shim machinery

Adds `loqs/internal/lega... (continued)

1353 of 1482 branches covered (91.3%)

Branch coverage included in aggregate %.

7713 of 8630 relevant lines covered (89.37%)

0.89 hits per line