Tatsh / sbclaude / 32093141648

100%

push

github

container: bridge the gpg agent socket at the runtime path always

Signing in the box failed with "Inappropriate ioctl for device" whenever
the host's agent socket already sat at /run/user/<uid>/gnupg/S.gpg-agent,
which is the ordinary layout rather than an unusual one.

The mount onto that path was skipped when the host path matched it, on
the reasoning that a file is not mounted onto itself. The two are not the
same file: /run/user/<uid> inside the box is its own tmpfs, so the box
was left with nothing at the very path its gpg prefers. gpg does not
report a missing agent, it starts one of its own, and that agent has an
empty passphrase cache and can only reach pinentry-curses, which needs a
TTY the box does not have.

Mount unconditionally, as the comment above it already described. The
home fallback alone was enough until something began creating
/run/user/<uid> in the box, which is what --wayland and --ssh do, so the
symptom appeared to come and go for reasons unconnected to signing.

The test asserted the mount was absent, so it is inverted rather than
added: it encoded the defect as the intended behaviour.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

90 of 90 branches covered (100.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

666 of 666 relevant lines covered (100.0%)

5.0 hits per line