Tatsh / deltona / 32092981698

100%

push

github

gmail: report what Google said and ease re-authorisation

Consent lapses on a schedule of Google's choosing, so the message shown
when it does is the whole diagnostic, and it was wrong twice over.

It asserted the refresh token was "probably expired or revoked" without
reading the response. One status covers an expired grant, a revoked one,
a clock skew, and a mismatched client, so the guess was as likely to
mislead as to help. Quote what Google reported instead, trimming the
full stop it supplies so it does not double up with the one this
sentence adds.

It then printed the entire first-time setup, telling someone whose only
problem was a lapsed consent to open the Google Cloud console and create
an OAuth client that already exists. Raise GmailAuthorizationError when
the stored authorisation is refused, whether by the token endpoint or by
Gmail answering 401 or 403, and let it select a message that asks only
for authorisation. The full setup stays for the case it describes, where
nothing is stored yet.

Both messages now name the command to run rather than a bare list of
options, since two commands share them and the reader has to know which
one to type.

Make --client-secret optional. The client id and secret sit in the
keyring beside the refresh token, so authorising again needs neither the
console nor the downloaded file, and passing it stays available for
anyone using a client of their own.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

459 of 459 branches covered (100.0%)

Branch coverage included in aggregate %.

31 of 31 new or added lines in 2 files covered. (100.0%)

3796 of 3796 relevant lines covered (100.0%)

4.0 hits per line