qutip / qutip / 32090160353

92%

Build Type

push

github

Committed by web-flow

Commit Message

Fix solver output isherm for non-Hermiticity-preserving dynamics (#2940)

* Fix solver output isherm flag for non-Hermiticity-preserving dynamics

Do not copy the initial state's isherm metadata onto evolved states.
Qobj.isherm recomputes from the actual data so mesolve/sesolve outputs
report Hermiticity correctly when the generator does not preserve it.

Fixes #2410

* Rename changelog entry to PR number 2940

* Add TODO on isherm recomputation cost

* Preserve isherm metadata for standard master equations

Mark Hamiltonian-and-collapse-operator RHS construction as Hermiticity-preserving so solver output can retain the cached flag without rescanning every state. Leave user-supplied superoperators uncached unless their evolved data is checked.

* Harden contributors plot against GitHub API rate limits

RTD builds treat plot exceptions as warnings-as-errors, so anonymous
GitHub API 403s were making docs checks flake.

* Drop docs RTD change; cache isherm for SME/SSE

Move the contributors plot fallback to a separate PR. Stochastic solvers
always take an operator Hamiltonian, so set _rhs_preserves_hermiticity for
SMESolver and SSESolver.

* Use Qobj.ishp for Hermiticity-preserving superoperator RHS

After #2886, constant superoperator generators that are Hermiticity-
preserving can take the fast isherm cache path. Check ishp on Qobj
before any QobjEvo conversion, per Paul's suggestion.

* Guard ishp probe for Qobj subclasses without _ishp

qutip-jax's Qobj subclass lacks the _ishp attribute, so reading the ishp
property raises AttributeError. Default the probe to False there.

* fix(solver): use cached Qobj._ishp for hermiticity flag

Avoid Qobj.ishp which may compute the Choi matrix. Only trust the
already-known Hermitian-preserving cache, per review.

* Recognise constant HP superoperators after QobjEvo conversion

mesolve() wraps H in a QobjEvo before constructing MESolver, so the
Qobj-only _ishp check never fired for users calling mesolve() rather t... (continued)

Coverage Stats

5 of 5 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

14231 of 16426 relevant lines covered (86.64%)

3.44 hits per line