IgniteUI / igniteui-webcomponents / 32046820334

98%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(controllers): fix gesture/fullscreen bugs and cut per-event work (#2335)

Fixes:
- Gestures never reset `touch-action`. It was cleared by assigning
  `undefined`, which CSSOM stringifies to an invalid value and ignores, so
  the property kept its previous value. After the first swipe on
  `igc-carousel` the element stayed at `touch-action: none` and native
  panning over it was permanently dead.
- Gestures emitted a phantom swipe on a plain press. Without a
  `pointermove` the current pointer state stayed at the zeroed default, so
  the delta was measured against `{x: 0, y: 0}` - a tap low on the page and
  near the left edge satisfied the "up" threshold. The current state is now
  seeded from the pointerdown.
- `requestFullscreen()` rejections went unhandled and left the controller
  reporting a fullscreen state the document was not in. The state is now
  rolled back and the host re-rendered.

Performance:
- `RootClickController` built one composed path per active host on every
  pointerdown and click, plus a `Set` per host to hold at most two
  elements. A single path is now shared across the hosts.
- `KeyBindingController` resolved the composed path twice and lowercased
  `event.key` up to three times per key event, and re-sorted an already
  sorted modifier list on every combination lookup.
- `MutationController` ran one `matches()` per configured selector per
  node; the selector list is now joined once into a single selector, and
  change aggregation no longer builds intermediate arrays per record.
- The root scroll listener is passive. It called `preventDefault()` on
  `scroll`, which is not cancelable, so a non-passive document-wide capture
  listener was blocking scrolling for nothing.
- `KeyboardFocusRingController` requested an update on every `pointerup`
  and `focusout` even when the state had not changed.
- `SlotController` caches its slot lookups, guarded on `isConnected` so a
  conditionally rendered slot cannot go stale.
- Sm... (continued)

Coverage Stats

6870 of 7205 branches covered (95.35%)

Branch coverage included in aggregate %.

255 of 262 new or added lines in 12 files covered. (97.33%)

1 existing line in 1 file now uncovered.

48680 of 49292 relevant lines covered (98.76%)

1447.13 hits per line