containernetworking / plugins / 32033213785

53%

master: 55%

Pull #1293

github

pkg/ip: preserve address family and reject underflow in intToIP

intToIP decided the result length from the minimal big.Int encoding, so a low IPv6 value whose leading bytes are zero (NextIP(::ff:ffff)) came back as a 4-byte IPv4 address. And because big.Int.Bytes returns the absolute value, PrevIP below the first address of a family returned the wrapped value instead of nil.

Decide the family width first, reject sign-negative underflow and oversized overflow, and always return the family's fixed width. Add regressions for IPv6 family preservation and both family minima.

Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>

17 of 17 new or added lines in 2 files covered. (100.0%)

5018 of 9544 relevant lines covered (52.58%)

27.88 hits per line