supabase / supabase-flutter / 32018797734

89%

push

github

fix(realtime): parse whole-number doubles in toInt transformer (#1718)

## What kind of change does this PR introduce?

Bug fix / hardening.

## What is the current behavior?

The `toInt` transformer in
`packages/realtime_client/lib/src/transformers.dart` falls back to
`int.tryParse(value.toString())`, which returns null for whole-number
doubles such as `1.0` or the string `'1.0'`. In practice Postgres does
not send `1.0` for `int4`/`int8` columns, so this has not caused issues,
but the transformer silently dropped such values instead of converting
them.

## What is the new behavior?

- `double` inputs that are whole numbers (for example `1.0`) now convert
to `int`. Non-finite values and values outside the 64-bit integer range
return null instead of clamping.
- String inputs still try `int.tryParse` first, then accept an integer
with an all-zero decimal fraction (for example `'10.0'` or `'-3.000'`).
The integer part is parsed directly, so values above 2^53 keep exact
precision instead of being rounded through `double`.
- Non-integral values (`10.5`, `'10.5'`), scientific notation (`'1e3'`),
`NaN`, and infinities return null rather than silently truncating or
rounding.

Test cases were added for all of the above, including regression
coverage above 2^53 and outside the 64-bit integer range.

## Additional context

No public API changes, `toInt` is `@internal`.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Improved numeric conversion for whole-number decimal values, decimal
strings, and scientific notation.
* Invalid, fractional, infinite, out-of-range, and non-numeric values
are now safely rejected.

* **Tests**
* Expanded coverage for valid and invalid numeric formats, including
large values, fractional values, scientific notation, and non-finite
numbers.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

7 of 7 new or added lines in 1 file covered. (100.0%)

5732 of 6495 relevant lines covered (88.25%)

4.11 hits per line