raystack / frontier / 31998174748

49%

main: 49%

Pull #1887

github

fix(permission): make the response key lossless and migrate its readers

The key field is the replacement for the deprecated namespace/name
response fields, but reading it back was lossy: a name with dots failed
to split (the parser demanded exactly 3 dot-parts), and a namespace
without a slash silently gained a /default suffix on the way in.

Split the key into at most 3 parts so everything after the namespace is
the name, dots included. Guard the response transform: the key must
parse back to the exact stored namespace/name pair, or the request
fails instead of returning a key that reads back as a different
permission.

With the key exact, move the remaining readers of the deprecated
fields onto it: the permission reconciler, the permission CLI output,
and the e2e assertions (part of #1782).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

14 of 21 new or added lines in 4 files covered. (66.67%)

19537 of 40088 relevant lines covered (48.74%)

15.66 hits per line