lsm / HyperNeo / 31992055349

79%

Build Type

push

github

Committed by web-flow

Commit Message

fix(daemon): raise default SDK startup timeout 15s → 60s (#2549)

* fix(daemon): raise default SDK startup timeout 15s → 60s

Cold-starting an SDK subprocess (fresh worktree + resumed transcript)
measures ~4-5s solo, and ten simultaneous cold-starts all exceeded the
old 15s default. The timer only guards silent hangs — real spawn
failures exit and are detected immediately — so a generous default is
cheap insurance. HYPERNEO_SDK_STARTUP_TIMEOUT_MS override unchanged;
hint strings print the effective value.

The 60s window stays below the delivery-turn stall watchdog's 3min
no-activity window so a silently hung startup is aborted by this timer
first (ordering documented at the constant). Note: the delivery lane's
35s settlementGraceMs is ordered against the job queue's 30s ack bound,
not against this window.

Replaced a vacuous test that hardcoded the old 15000 default with an
assertion that the startup-timeout hint prints 'current: 60000ms'.

* fix(daemon): address review on startup-timeout raise (#2549)

Review follow-ups: document the two 30s bounds (MESSAGE_QUEUE_TIMEOUT_MS,
awaitDeliveryConsumption) that cap delivered-kickoff tolerance below the
60s window and note that >30s herd convergence belongs to the sibling
retry-backoff/stale-reclaim tasks; point the stall-watchdog reference at
DELIVERY_TURN_NO_ACTIVITY_MS (agent-session.ts) instead of the prose
comment in query-options-builder.ts; fix .env.example (still said
Default: 15000 / example 15000 — copy-pasting would LOWER the timeout)
and note ACP keeps 15000 under the same variable; drop a stale
"15-second timer" comment; wrap the five HYPERNEO_SDK_STARTUP_TIMEOUT_MS
save/restores in acp-query-runner.test.ts in try/finally so a failing
assertion cannot leak '20' into the shared worker; and pin the override
path by asserting 'current: 10ms' in the online startup-timeout test.

* test(daemon): delete ambient HYPERNEO_SDK_STARTUP_TIMEOUT_MS in unit preloads

query-runner.ts snapshots the startup t... (continued)

Coverage Stats

43577 of 59193 branches covered (73.62%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

59353 of 71301 relevant lines covered (83.24%)

3799.94 hits per line