FROSADO / onecloudriver / 31941493177

78%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fs): allow renaming locally-created items before upload (#83) (#84)

Locally-created files hold a provisional local-<hex> ID until the
background upload completes. doRename sent PATCH /me/drive/items/
local-<hex> to Graph, which answered HTTP 400 invalidRequest, so
renaming a brand-new file (e.g. Obsidian "Sin título.md" ->
"Test.md") failed with EIO.

- doRename: when the child ID is local, skip the remote
  RenameItem/MoveItem call and update the in-memory cache (name and
  parent) plus the pending upload session, so the file is created
  remotely with the new name in the new folder.
- UploadManager.RenameSession: also updates in-flight sessions; when
  the upload finishes, applyInflightTargetChange renames/moves the
  remote item (using the real ID from the upload response) if the
  target changed mid-flight.
- doRmdir: same isLocalID guard as doUnlink/doRename, as defense in
  depth (folders always carry real IDs today, so this is
  unreachable).
- Tests: rename of a local item (zero Graph calls, pending upload
  updated), RenameSession for pending and in-flight sessions,
  rename-during-in-flight-upload race with blocked PUT, rmdir of a
  local folder, and FUSE delete-and-recreate-same-name.

Generated with Codebuff 🤖

Co-authored-by: Codebuff <noreply@codebuff.com>

Coverage Stats

55 of 68 new or added lines in 2 files covered. (80.88%)

2 existing lines in 1 file now uncovered.

3836 of 4964 relevant lines covered (77.28%)

493.78 hits per line