wegamekinglc / Derivatives-Algorithms-Lib / 31930251504

90%

master: 90%

Build Type

Pull #293

github

Committed by wegamekinglc

Commit Message

Fix review and static-analysis findings on the debug dumps

- Replace a mixed-type ternary in TreeParen that clang and gcc reject
  (base_t and String_ branches both convert to each other, so the
  conditional operator has no common type; MSVC accepted it)
- Pass JSON string bytes through as unsigned char so multi-byte UTF-8
  is emitted verbatim instead of being \u-escaped per byte on platforms
  with signed char
- Parenthesize a pow operand under unary negation; "−a ^ b" reads as
  either −(a ^ b) or (−a) ^ b
- Construct a fresh Debugger_ per statement so the IR of earlier
  statements does not pile up on the visitor stack during a dump
- Keep the dal-public dump helper out of the core Dal::Script namespace
  (Dal::Detail instead)
- Split the inline/tree/JSON renderers into per-family helpers and
  table-driven precedence/width lookups to bring every function under
  the complexity budget Codacy enforces; rendering output is unchanged
  and pinned by tests, now including the neg-pow and UTF-8 cases

Pull Request Pull Request #293: feat: add script product JSON and tree debug dumps

Coverage Stats

344 of 432 new or added lines in 3 files covered. (79.63%)

1 existing line in 1 file now uncovered.

10049 of 11197 relevant lines covered (89.75%)

2452048.32 hits per line