lsm / HyperNeo / 31920804557

79%

Build Type

push

github

Committed by web-flow

Commit Message

fix(web): deterministic Dropdown Escape handling + hermetic unit-test WebSocket guard (#2513)

* fix(web): deterministic Dropdown Escape handling + hermetic unit-test WebSocket guard

Two web-suite CI flakes rooted and fixed:

1. Dropdown 'should close when Escape key is pressed' (failed run
   31900045333): the component deferred BOTH document listeners behind
   setTimeout(0), and the test compensated with a fixed 10ms sleep —
   a timing gamble that loses under CI load (the open render is
   observable before Preact flushes the effect, and the deferred
   listener can attach later than the sleep even when the effect has
   run). An Escape keydown can never be the interaction that opened
   the menu, so its listener now attaches synchronously; the test
   dispatches Escape inside waitFor so it retries until the listener
   has landed — no fixed sleep at all.

2. SpaceIsland-attributed 'Vitest caught 35 unhandled errors' (failed
   run 31915057321): every rejection was 'WebSocket to
   ws://localhost:9283/ws closed before open (code=1006)'. Root:
   space-store's global init reaches the shared websocket-client-
   transport, which opens a REAL socket in unit tests; under CI load
   the rejection timing lets it escape as unhandled rejections that
   vitest fails the run on — and the flaky-tests registry cannot
   absorb it (no JUnit testcase fails). Mirror the daemon unit fetch
   guard (#2496): replace the WebSocket constructor with one that
   fails loudly at the call site, stashing the original as
   __originalWebSocket for tests that explicitly opt in. Local full
   suite with the guard: 6891/6891 green — the guarded constructor
   fires exactly where space-store already catches and logs init
   failure.

* fix(web): register Dropdown Escape listener in a layout effect

Review feedback: a passive useEffect still defers the attach past the
commit that exposes the menu, leaving a real-user window where a
keydown is missed. Register Escape in useLayo... (continued)

Coverage Stats

42627 of 57975 branches covered (73.53%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

58107 of 69941 relevant lines covered (83.08%)

3860.59 hits per line