FlexMeasures / flexmeasures-client / 31916624345

97%

push

github

feat: allow unit param in file upload (#221)

* feat: allow unit param in file upload

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* fix: require server 0.30.0 when uploading a file with a unit

Servers before v0.30.0 do not read a "unit" form field on the sensor data
upload endpoint. Their webargs location loader copies only the file and the
"belief-time-measured-instantly" field out of the form, so an unknown "unit"
never reaches marshmallow and no validation error is raised. Ingestion then
falls back to `fields.get("unit", sensor.unit)`, which makes the unit
conversion a no-op: the file's values are recorded as if they were already
in the sensor's unit, and the request still returns 200.

The result is silent data corruption (e.g. a 1000x error when uploading W
to a kW sensor) with no signal to the caller. Fail before sending anything
instead, but only when a unit is actually passed, so existing file uploads
are unaffected and incur no extra request.

Base versions are compared via _server_version_at_least so that pre-release
builds such as 0.30.0.dev5, which already expose the field, are accepted.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix: report the missing params when only a unit or prior is passed

Dropping unit from json_params is right for the mutual-exclusivity check,
since a unit can now accompany a file upload. But that same list also picks
the error message, so a lone unit stopped counting as "something was passed"
and post_sensor_data(sensor_id=1, unit="MW") reported that neither mode was
chosen -- while a unit sat right there in the call. prior was already in
that position.

Keep unit and prior out of the mode decision, but let them select the
message, so the caller is told which parameters are missing instead. The
genuinely empty call is unaffected.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* test: cover a server that reports no version on unit file upload

The guard leans on _server_version_at_l... (continued)

15 of 15 new or added lines in 1 file covered. (100.0%)

706 of 731 relevant lines covered (96.58%)

9.66 hits per line