fyne-io / fyne / 31893423935

60%

Build Type

push

github

Committed by web-flow

Commit Message

widget: rebuild form item render slot when its Widget is replaced (#6459)

* widget: rebuild form item render slot when its Widget is replaced

ensureRenderItems() only ever appended render objects for newly added
Items, so replacing an existing FormItem.Widget after the form had
already been rendered was silently ignored by Refresh(), unlike Text
changes which are applied in place by updateLabels().

Fixes #1966

* widget: reset stale per-widget FormItem state on widget swap

Address review feedback on the previous commit: when an item's Widget
is swapped, also detach the old widget's validation callbacks and
reset validationError, invalid, wasFocused and helperOutput, so none
of it leaks from the widget that used to occupy the slot.

Coverage Stats

28 of 28 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

27190 of 45451 relevant lines covered (59.82%)

813.22 hits per line