99designs / gqlgen / 31861924908
0%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 0
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 0.0%. Remained the same
31861924908

push

github

web-flow 
fix: batch resolver parent registration (#4281)

* fix: batch resolvers for value slice parents

* chore: refresh generated batch resolver fixtures

* graphql: add helpers for batch parent handling

Generated code recovered batch parents itself: it looked up the group,
type-asserted the parents, read the parent index off the path, and derived
the field's response key from the alias. Four concerns, emitted inline into
every batch field of every generated file.

Move them behind BatchParentsFor and BatchParents.FieldResult, and add
WithBatchParentValues for the case where the marshaler holds a []T rather
than a []*T and has to take the address of each element.

Nothing existing changes signature, so code generated by an older gqlgen
still compiles against this runtime.

* codegen: track batch resolver fields per type

HasBatchResolverFields answers a schema-wide question: does anything,
anywhere, use a batch resolver. Marshalers need a narrower one, namely
whether this type does, so add HasBatchFields and BatchImplementors.

The set is computed once and cached rather than populated in BuildData,
because plugins may add fields after the data is built and templates render
after every plugin has run.

Per-schema builds under the follow-schema layout hold only the objects
declared in their own file, so addBuild propagates the schema-wide set the
same way it already propagates AllDirectives. Without that an interface
whose implementors live in different schema files would only see the ones
sharing its file.

* codegen: register batch parents only where they are used

Three problems in the slice marshaler, all in the same guard.

A []T field stored the values themselves as batch parents, but resolvers
take []*T, so the generated type assertion failed and every parent fell
back to a single-parent call. Use WithBatchParentValues for that case.

$type.Elem.Definition follows through list wrappers, so [[Thing!]!]!
reported Thing's kind and the outer list register... (continued)

0 of 0 relevant lines covered (NaN%)

0.0 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31861924908.1 0
0.0
 GitHub Action Run
Source Files on build 31861924908
Detailed source file information is not available for this build.