ossia / score / 31856955034

19%

Build Type

push

github

Committed by jcelerier

Commit Message

library: fix the library scan finding nothing on Windows

The Windows builds have scanned no library at all since llfio was enabled
there in 7789e60aa. NtQueryDirectoryFile() returns at most ~64Kb of entries
per call however large a buffer it is given, so llfio cannot enumerate a
directory of more than roughly 600 short-named files as an atomic snapshot,
and by default fails the read rather than returning the entries. That error
aborts algorithm::contents() for the whole tree, so for_all_files() walked
nothing: no presets, no devices, no cues, no Faust or JSFX effects.

The stock user library has three such directories (Presets/GLSL_shaders/grigm
at 1513 entries, Presets/Vertex Shader Art/{audioreactive,basic} at 1120 and
959), so a default install scanned zero of its 6041 files. The system library
panel is a QFileSystemModel and kept listing them, which is why this looked
like "the library downloaded but score sees no presets".

Ask for llfio's permit_racy_reads, which returns the entries when a snapshot
is not possible, and report a failed enumeration instead of silently
presenting it as an empty library.

The llfio bump carries the two commits needed for that, and points at the
traverse-enumeration-flags branch until they are merged upstream.

Coverage Stats

2 of 5 new or added lines in 1 file covered. (40.0%)

127 existing lines in 3 files now uncovered.

31824 of 204879 relevant lines covered (15.53%)

1581.27 hits per line