Tatsh / destin / 31853577959

100%

Build Type

push

github

Committed by Tatsh

Commit Message

feat(misc/sc_info): read every bundle in a download

A download usually carries more than one bundle: an app extension under
PlugIns and a watch app under Watch each hold an SC_Info of their own.
Read all of them instead of refusing anything that is not a lone bundle.

Only the application sits at Payload/<name>.app, so that depth identifies
it. Manifest.plist corroborates it, listing the sub-bundle sinfs by path
and its own without one. --main-bundle keeps only that bundle, and
--bundle NAME keeps one named in full or by its last component.

The JSON is now a list, one entry per bundle, each naming its bundle and
whether it is the application. The report separates bundles with a blank
line and heads each with its path.

Also cap the report's record listing at ten and count the rest, since a
bundle can carry hundreds; the JSON still carries all of them. Fall back
to the region-less App Store link when no storefront can be established,
rather than emitting nothing.

The .supp record hypothesis in the docstring was wrong: a free app with
no in-app purchases carries 562 records, which rules out one per
purchase.

Signed-off-by: Andrew Udvare <audvare@gmail.com>

Coverage Stats

1771 of 1785 branches covered (99.22%)

Branch coverage included in aggregate %.

91 of 92 new or added lines in 3 files covered. (98.91%)

1 existing line in 1 file now uncovered.

13745 of 13868 relevant lines covered (99.11%)

4.96 hits per line