archetech / archon / 31838413435

95%

push

github

feat: Restore CLI command parity in scripts/archon-cli.js (#886)

AGENTS.md requires scripts/archon-cli.js, packages/keymaster/src/cli.ts and
python/keymaster/src/keymaster/cli.py to stay in parity. The two
library-backed CLIs held that line and had identical command sets; the
script had drifted 40 commands behind.

That script is the user-facing `archon` command (./archon runs it inside
the cli container), so whole families were unreachable for anyone driving
a node through it: dmail, lightning and address entirely, plus parts of
poll, nostr and credential. The integration CLI tests in tests/cli/ run
against the same entry point, so those commands had no coverage either.

Port all 40. Every one already had a matching KeymasterClient method, so
this is a backlog of unwritten wrappers rather than a capability gap --
the commands are transcribed from cli.ts with the TypeScript annotations
dropped, plus the sleep helper and two zap-status constants that
lightning-zap needs.

perf-test stays script-only and is now recorded as a deliberate exception
with its reason: it times round trips through the Keymaster service, and
the other two CLIs use the library directly so have no service round trip
to measure.

Widen tests/keymaster/cli-parity.test.ts from the DIDComm family to every
command, so AGENTS.md's rule is enforced by CI rather than by memory:

- identical command sets across all three CLIs
- identical options per command across the two JS CLIs
- identical argument shape per command across the two JS CLIs, comparing
  <> and [] rather than placeholder names, since change-registry calls the
  same argument `did` in one CLI and `id` in the other and that is
  cosmetic
- a guard that a script-only exception which appears in the other CLIs
  fails, so a stale exception cannot quietly hide new drift

Verified the widened test fails on a removed command, a removed option and
a changed argument shape; that commander accepts all 144 signatures; and
that eslint... (continued)

3630 of 4089 branches covered (88.77%)

Branch coverage included in aggregate %.

8274 of 8557 relevant lines covered (96.69%)

689.6 hits per line