aws / aws-application-networking-k8s / 31819211059

51%

main: 44%

Pull #987

github

fix(vpc-association): Surface ConflictException as terminal status condition

When CreateServiceNetworkVpcAssociation returns a ConflictException
because the VPC is already associated with another service network,
the controller now:

1. Detects the permanent conflict (vs transient CREATE_IN_PROGRESS)
2. Sets Accepted=False with reason Conflicted on the VpcAssociationPolicy
3. Stops retrying (returns nil instead of looping with backoff)

This gives users immediate visibility via kubectl instead of requiring
them to check controller logs for the permanent failure.

Transient ConflictExceptions (CREATE_IN_PROGRESS) are still retried
via the standard RequeueNeededAfter mechanism.

Fixes: https://github.com/aws/aws-application-networking-k8s/issues/984

13 of 15 new or added lines in 2 files covered. (86.67%)

6320 of 12512 relevant lines covered (50.51%)

0.57 hits per line