kubernetes-sigs / kubebuilder / 31800129709
87%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 103
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 86.557%. Remained the same
31800129709

push

github

web-flow 
🐛 (CLI; alpha generate) Preserve the customised Grafana config when alpha generate runs in place (#5968)

* 🐛 Preserve the customised Grafana config when alpha generate runs in place

An in-place run cleans the project directory before scaffolding, and
grafanaConfigMigrate then reads the config from that same directory, so
the customised grafana/custom-metrics/config.yaml it is meant to carry
forward is already gone and a scaffolded default takes its place.

Read the file before the cleanup and restore that content during the
Grafana plugin migration, the same way the boilerplate file is already
preserved across the cleanup.

* 🐛 Track the Grafana config's existence separately from its content

An existing empty config.yaml was indistinguishable from a missing one,
so an in-place run left the scaffolded default in place instead of
restoring the empty file. Record existence in its own flag, the same way
the boilerplate path does, and restore whenever the file was present.

* 🐛 Surface Grafana config stat errors and cover the preservation end to end

Checking for an existing Grafana config treated every stat error as the
file being absent. Only os.ErrNotExist means that; a permission or other
filesystem error now fails the run before the cleanup deletes the file
it could not check.

The migrateGrafanaPlugin unit tests exercise the restore in isolation,
so none of them would notice if the command captured the config after
the cleanup instead of before it. Add integration coverage through the
command for the two affected runs: in place, and --input-dir without
--output-dir. Both customise the scaffolded config, regenerate, and
expect the customisation back on disk and in the rebuilt dashboard.

8667 of 10013 relevant lines covered (86.56%)

291.03 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31800129709.1 103
86.56
 GitHub Action Run
Source Files on build 31800129709