SwissDataScienceCenter / renku-data-services / 31794430062

86%

Build Type

push

github

Committed by web-flow

Commit Message

feat: update apispec for polymorphic resource class definition (#1388)

## Summary

Adds an optional FirecREST `remote` override to resource classes so that a single FirecREST resource
pool can hold classes targeting different Slurm `system_name`/`partition` combinations, and can choose
whether Amalthea forwards the class CPU, memory, and GPU to FirecREST or lets the HPC grid pick them.
A resource class inherits the kind of its parent pool.

## Motivation and context

We originally targeted only CSCS, where the smallest allocation is a full node, so it was enough to let
Slurm set the defaults for `CPUS_PER_TASK`, `GPUS`, and `RAM`. As we expand to other grids (Idiap) we
need to tell Amalthea exactly how much of a node to request, and we want a single resource pool to
support multiple class-level target configurations rather than forcing one pool per Slurm target.

## Behavior

- Resource classes gain an optional `remote: RemoteClassConfigurationFirecrest`. It is only allowed when
  the parent pool's remote kind is `firecrest`; supplying it on a non-FirecREST class is rejected. A
  class's remote kind is its parent pool's remote kind.
- FirecREST classes support per-class `system_name` and `partition` overrides, falling back to the pool
  defaults when omitted. This lets one pool hold multiple classes targeting different Slurm systems or
  partitions.
- FirecREST classes expose `forward_resource_values` (boolean, default `false`). When `false` (the
  default) the HPC grid selects CPU, memory, and GPU, and the class values are used only for display and
  quota matching. When `true`, Amalthea forwards the CRD CPU, memory, and GPU values to FirecREST.
- FirecREST classes require an integer `cpu` value; fractional CPU is rejected by the validators.
- On session launch for a FirecREST pool, the service emits `RSC_FIRECREST_SYSTEM_NAME`,
  `RSC_FIRECREST_FORWARD_RESOURCE_VALUES` (always emitted, as `"true"`/`"false"`), and
  `RSC_FIRECREST_PARTITION` when a ... (continued)

Coverage Stats

131 of 140 new or added lines in 8 files covered. (93.57%)

28 existing lines in 8 files now uncovered.

27797 of 32415 relevant lines covered (85.75%)

1.48 hits per line