nvidia-holoscan / holoscan-cli / 31792535755

79%

Build Type

push

github

Committed by web-flow

Commit Message

fix: preserve source-project context (#221)

* fix: preserve source-project context

Forward local SDK roots through test containers, preserve declared Module identity across checkout and mount paths, and make lint hooks use the selected CLI Python and root lint requirements.

Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* test: consolidate source-project regressions

Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fix: align module name resolution

Use one normalization rule for metadata discovery and module packaging, and cover the lint environment and requirements precedence review cases without adding standalone test functions.

Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fix: resolve pre-commit from PATH when the interpreter cannot import it

Lint probed only `sys.executable -m pre_commit`, so an installed pre-commit
that is on PATH but not importable by the CLI's own interpreter was reported
as missing. The CLI then tried to pip-install a second copy, which cannot
succeed in `uvx`/`uv tool` environments because they are built without pip;
the run failed with "No module named pip".

Resolve the runner from the active interpreter first, so a project-pinned
pre-commit in the same environment still wins, and fall back to an executable
on PATH. Resolution now also runs under --dryrun so the printed command
matches what would really execute. Implicit installation is unchanged and
remains automatic, but it is now the last resort rather than the first
response, and it reports an actionable message when the interpreter has no
pip instead of failing inside pip.

Also run the repository's own lint through `holoscan lint` in CI so a
regression in runner resolution, root discovery, or path scoping surfaces
here rather than in a downstream project, and correct the `--fix` help text
to state that it is a no-op alias.

Co-Authored-B... (continued)

Coverage Stats

23 of 36 new or added lines in 5 files covered. (63.89%)

2 existing lines in 2 files now uncovered.

3259 of 4151 relevant lines covered (78.51%)

0.79 hits per line