NVIDIA / nodewright / 31759836687
79%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 79.217% (-0.03%) from 79.248%
31759836687

push

github

web-flow 
test(operator): wait on the webhook cache when deleting a DeploymentPolicy (#468)

The DeploymentPolicy delete specs delete their referencing CR, wait for the
apiserver to report it gone via k8sClient, then delete the policy. That last
delete goes through the REGISTERED validating webhook in the manager, which
lists CRs through the manager's cached client -- not through k8sClient. So the
wait proves the wrong thing: the apiserver has applied the delete, but the
informer can still return the object, and the policy delete is rejected with
"still referenced by 1 NodeWright(s)".

Seen in CI on an unrelated PR:

  admission webhook "vdeploymentpolicy-nodewright.kb.io" denied the request:
  cannot delete DeploymentPolicy "policy-to-be-freed": still referenced by
  1 NodeWright(s): [test-nodewright-temp]

Note the existing wait is correct for the direct deploymentPolicyWebhook
.ValidateDelete call that precedes it -- that webhook is constructed in the spec
with k8sClient. It is the cleanup delete on the next line, served by the
manager's copy of the webhook, that nothing covers.

This is the removal-direction twin of #467, which added
waitForPolicyInWebhookCache for the create direction. Same fix, same shape: wait
on the client the webhook actually reads. Applied to both API groups, matching
#467's scope.

Also refreshes the README header, which still pointed at the pre-rename repo:
the pipeline and coverage badges now target NVIDIA/nodewright, the dead Go
Report Card badge is dropped, and the support line points at this repo's issues.
The GitHub Discussions link goes with it -- Discussions is not enabled on this
repository, so it was offering a channel that does not exist.
NVIDIA/skyhook-packages is a separate repository and is left alone.

Verified by running both webhook suites six times (--repeat=5): 43/43 and
130/130 specs green each pass.

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

10215 of 12895 relevant lines covered (79.22%)

7.93 hits per line

Coverage Regressions

Lines Coverage ∆ File
4
83.76
 -0.17% operator/internal/controller/skyhook_controller.go
Jobs
ID Job ID Ran Files Coverage
1 31759836687.1 59
79.22
 GitHub Action Run
Source Files on build 31759836687