NVIDIA / nodewright / 31746429771

79%

Build Type

push

github

Committed by web-flow

Commit Message

feat(operator): publish nodewright_* metrics alongside deprecated skyhook_* (#462)

Metric names and label keys are the identifiers users bake into Grafana
dashboards, Prometheus alerting rules, and recording rules, so the Skyhook
to NodeWright rename cannot swap them in place without breaking every
consumer the moment they upgrade. All 14 metrics now publish under both
skyhook_* (label skyhook_name) and nodewright_* (label nodewright_name),
carrying identical values and identical remaining labels, so migrating a
query is a two-token swap.

The legacy set is removed in v0.20.0, the same release that drops the
legacy skyhook.nvidia.com API group, so users have one deadline to plan
against rather than two.

PUBLISH_LEGACY_METRICS=false (chart:
controllerManager.manager.env.publishLegacyMetrics) unregisters the
deprecated collectors at startup, for operators who would rather halve
their exported series count than keep the compatibility window. It
defaults to true, so an upgrade that sets nothing keeps the window.

Chainsaw assertions move to the new names, with one block in
simple-nodewright left on the legacy names so the deprecation window is
exercised end to end rather than only asserted in unit tests.

Closes #461

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

Coverage Stats

77 of 80 new or added lines in 2 files covered. (96.25%)

2 existing lines in 1 file now uncovered.

10171 of 12891 relevant lines covered (78.9%)

7.94 hits per line