decentraland / profile-images / 31743493857

89%

push

github

fix: address PR #152 review findings — async anti-pattern, fire-and-forget cleanup, tmpdir path (#163)

- Refactor runGodot to move async setup (writeFile, mkdir) before the Promise
  constructor, eliminating the `new Promise(async ...)` anti-pattern that could
  cause unhandled rejections on future edits.
- Switch cleanupTempFile calls from `await` to fire-and-forget (`void`) since
  errors are already caught internally — avoids coupling resolve timing to I/O.
- Use `path.join(os.tmpdir(), ...)` for temp avatar files instead of resolving
  against CWD, making the path robust across different execution contexts.
- Update tests to assert temp file paths under os.tmpdir().

Closes #162

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

232 of 286 branches covered (81.12%)

Branch coverage included in aggregate %.

22 of 32 new or added lines in 1 file covered. (68.75%)

576 of 621 relevant lines covered (92.75%)

24.84 hits per line