stacklok / toolhive / 31730302063

70%

Build Type

push

github

Committed by web-flow

Commit Message

Reset the LLM config when the last tool is torn down (#6295)

* Clear Bedrock compat when tearing down Claude Code

Bedrock compat is persisted so a later plain "thv llm setup" keeps it,
but it applies to no client other than Claude Code. Tearing Claude Code
down therefore left the setting with no consumer, and only an explicit
--bedrock-compat=false could clear it. A subsequent setup — possibly
against a gateway that no longer forwards to Bedrock — silently re-pinned
the Bedrock model IDs and CLAUDE_CODE_DISABLE_EXPERIMENTAL_BETAS the user
had just removed, which reads as setup forcing Bedrock unconditionally.

Clear the persisted Bedrock config when Claude Code is among the reverted
tools. Stickiness across ordinary re-runs is unchanged.

* Clear client-scoped LLM settings stranded by teardown

Bedrock compat was not the only persisted setting that could outlive the
client it configures. Models has the same shape: it is read only by Claude
Desktop and, under Bedrock compat, Claude Code, yet it survived a full
teardown and was silently re-applied by the next setup.

Replace the Bedrock-specific check with a registry of client-scoped
settings, each naming the clients that consume it. Teardown clears any
entry left with no consumer among the still-configured tools and reports
what it removed, so a later setup no longer re-applies settings the user
tore down. A setting is preserved while any of its consumers remains, so
Models outlives a Claude Code teardown when Claude Desktop is still set up.

Settings that apply to every client, such as TLSSkipVerify, are not
registered and are unaffected.

* Reset the LLM config when the last tool is torn down

Replace the per-setting stranded-value pruning with a single rule:
teardown resets the whole LLM config once no configured tool remains.

Settings like Bedrock compat and the model list are deliberately sticky so
an ordinary "thv llm setup" re-run keeps them. Nothing ended that
stickiness, so a value could ou... (continued)

Coverage Stats

17 of 20 new or added lines in 1 file covered. (85.0%)

11 existing lines in 4 files now uncovered.

84684 of 120505 relevant lines covered (70.27%)

98.98 hits per line