NVIDIA / nodewright / 31722721694

79%

Build Type

push

github

Committed by web-flow

Commit Message

feat(cli): default install namespace to nodewright, discover it at runtime (#453)

The documented install namespace moves from `skyhook` to `nodewright` for new
installs. Namespaces cannot be renamed in place and Helm cannot move a release
between namespaces, so existing installs stay in `skyhook` indefinitely; nothing
is migrated and there is no deadline.

Because a blind default change would answer "not found" for every pre-rename
install, the CLI now discovers the operator's namespace when `--namespace` is
not passed: `nodewright`, then `skyhook` (printing a one-line note), then a
cluster-wide Deployment sweep, then a fallback to `nodewright` so the command's
own lookup reports the specific miss. An explicit `--namespace` is used verbatim.

This is not a compatibility break: both CRDs are cluster-scoped, so `--namespace`
only locates the operator Deployment and the package pods, and no command changes
which CRs it sees.

Also deduplicates the two DefaultNamespace constants into internal/cli/utils,
moves the kustomize overlay to nodewright-operator-system, and sweeps the
Makefile, chainsaw suites, scripts and docs. The chart needed no change: it
already sources the namespace from .Release.Namespace throughout.

Closes #436

Signed-off-by: Brian Lockwood <lockwobr@gmail.com>

Coverage Stats

43 of 49 new or added lines in 7 files covered. (87.76%)

220 existing lines in 3 files now uncovered.

10121 of 12839 relevant lines covered (78.83%)

7.91 hits per line