archetech / archon / 31708173324

95%

push

github

ci: Make native-module installs resilient to prebuild fetch failures (#879)

* ci: Make native-module installs resilient to prebuild fetch failures

Docker image builds have been failing across the matrix with:

    npm error prebuild-install warn install socket hang up
    ERROR: failed to solve: process "/bin/sh -c npm ci" did not
    complete successfully

prebuild-install fetches prebuilt native binaries from GitHub release
assets with a single request and no retry (see its download.js), so one
transient connection reset fails `npm ci`. The source-build fallback that
sqlite3 and @ipshipyard/node-datachannel both declare cannot rescue it,
because the node:*-slim base images have no Python or C++ toolchain --
the builds die on `gyp ERR! find Python`.

Nothing cached the result either: the image builds had no layer cache and
no workflow used npm caching, so a single push fired ~30 identical
anonymous downloads of the same two tarballs from one runner IP.

Two layers of defence:

1. Layer cache. Add cache-from/cache-to type=gha to docker-build.yml,
   scoped per image so the matrix legs don't evict each other. This needs
   setup-buildx-action, as the default docker driver cannot export cache.
   mode=min is enough since every Dockerfile here is single-stage. Most
   PRs don't touch the root lockfile, so their `npm ci` layer becomes a
   cache hit and never reaches the network at all.

2. Vendored prebuilds, for the PRs that do change the root lockfile.
   scripts/prefetch-prebuilds.mjs resolves versions from
   package-lock.json, reconstructs prebuild-install's URL template and
   downloads x64 + arm64 with retries. prebuild-install checks a local
   prebuilds directory before both its cache and the network, so the
   Dockerfiles copy that directory in and point at it via env var.

The prefetch is deliberately best-effort: on failure it warns and the
build falls back to fetching at npm-ci time, so an accelerator can never
itself break a build. The ta... (continued)

3616 of 4070 branches covered (88.85%)

Branch coverage included in aggregate %.

8245 of 8527 relevant lines covered (96.69%)

685.96 hits per line